RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818

[Alex Menkov]

On Wed, 11 Oct 2023 06:11:29 GMT, Hannes Greule <hgreule at openjdk.org> wrote:

> > The fix itself looks good to me. How did you tested the change? Looks like we don't have test coverage for the correctness of the dumped fields. Would be nice to add it.
> 
> Thanks. I ran `hotspot_serviceability` and also manually looked into more complex heap dumps. I agree that specific tests would be better. I'll need to figure out how that can be accomplished. If you have any pointers how to get started there, please let me know.

We have test library to parse hprof files in test/lib/jdk/test/lib/hprof
You can look at test/hotspot/jtreg/serviceability/jvmti/vthread/HeapDump/VThreadInHeapDump.java as an example of a test which generates heap dump for target application and verifies it contains expected data.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16083#issuecomment-1760192842