RFR: 8318484: Initial version of cdsConfig.hpp

[David Holmes]

On Thu, 19 Oct 2023 05:56:53 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> This is the first step for [JDK-8318483 - Move CDS configuration management into cdsConfig.hpp](https://bugs.openjdk.org/browse/JDK-8318483)
> 
> - Remove `Arguments::is_dumping_archive()` and `Arguments assert_is_dumping_archive()`
> - Add the following new APIs
> 
> 
> class CDSConfig {
>   static bool is_dumping_archive();
>   static bool is_dumping_static_archive();
>   static bool is_dumping_dynamic_archive();
>   static bool is_dumping_heap();
> };
> 
> 
> - Convert some use of `DumpSharedSpaces` and `DynamicDumpSharedSpaces` to these new APIs
> 
> (More APIs will be added in future sub tasks of [JDK-8318483](https://bugs.openjdk.org/browse/JDK-8318483))

Initial refactoring looks good. One query below.

Thanks

src/hotspot/share/cds/metaspaceShared.cpp line 778:

> 776: 
> 777: #if INCLUDE_CDS_JAVA_HEAP
> 778:   if (CDSConfig::is_dumping_heap()) {

This seems a new condition. Why is it needed now?

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16257#pullrequestreview-1686863583
PR Review Comment: https://git.openjdk.org/jdk/pull/16257#discussion_r1365002696