RFR: 8318484: Initial version of cdsConfig.hpp

Serguei Spitsyn sspitsyn at openjdk.org
Fri Oct 20 04:05:33 UTC 2023


On Thu, 19 Oct 2023 05:56:53 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> This is the first step for [JDK-8318483 - Move CDS configuration management into cdsConfig.hpp](https://bugs.openjdk.org/browse/JDK-8318483)
> 
> - Remove `Arguments::is_dumping_archive()` and `Arguments assert_is_dumping_archive()`
> - Add the following new APIs
> 
> 
> class CDSConfig {
>   static bool is_dumping_archive();
>   static bool is_dumping_static_archive();
>   static bool is_dumping_dynamic_archive();
>   static bool is_dumping_heap();
> };
> 
> 
> - Convert some use of `DumpSharedSpaces` and `DynamicDumpSharedSpaces` to these new APIs
> 
> (More APIs will be added in future sub tasks of [JDK-8318483](https://bugs.openjdk.org/browse/JDK-8318483))

Looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16257#pullrequestreview-1689170021


More information about the serviceability-dev mailing list