RFR: 8318447: Move NMT source code to own subdirectory
David Holmes
dholmes at openjdk.org
Fri Oct 20 06:37:33 UTC 2023
On Thu, 19 Oct 2023 20:06:50 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
> I think that NMT is deserving of its own subdirectory. Can we do a review of the changes before I fix the merge conflicts?
>
> 1. Moved all the nmt source code from services/ to nmt/
> 2. Renamed all the include statements and sorted them
> 3. Fixed the include guards
Looks okay for moving the NMT files.
The unrelated include file ordering changes just made it harder to review though.
Thanks.
src/hotspot/os/linux/os_linux.cpp line 65:
> 63: #include "runtime/threadCritical.hpp"
> 64: #include "runtime/threadSMR.hpp"
> 65: #include "runtime/threads.hpp"
This was correct originally - lowercase sorts before upper.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16276#pullrequestreview-1689327994
PR Review Comment: https://git.openjdk.org/jdk/pull/16276#discussion_r1366530642
More information about the serviceability-dev
mailing list