RFR: 8209595: MonitorVmStartTerminate.java timed out [v2]
Leonid Mesnik
lmesnik at openjdk.org
Fri Oct 20 15:24:32 UTC 2023
On Fri, 20 Oct 2023 13:30:49 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
>> From studying test failures, it looks like the way the test identifies its related processes is failing.
>> It checks the mainArgs of a process by attaching, and looks like it occasionally misses getting a valid match. The hasMainArgs method ignores exceptions as it is expecting some exceptions: it is going to test unrelated java process which happen to start.
>>
>> It should retry this main args check on failure, but not too many times to be a burden on other valid unrelated processes, and should also log the PIDs that have an issue so we can see if this is part of any future failure.
>>
>> Other small logging changes so we can see more easily the progress through the test.
>
> Kevin Walls has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>
> - Check main args fetching was ok. Increase sleep.
> - nits
> - Merge remote-tracking branch 'upstream/master' into MonitorVmStartTerminate
> - nit1
> - Comment, and move takeNap() sleep method.
> - 8209595: MonitorVmStartTerminate.java timed out
Marked as reviewed by lmesnik (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/16077#pullrequestreview-1690307180
More information about the serviceability-dev
mailing list