RFR: JDK-8318636: Add jcmd to print annotated process memory map [v3]

[Thomas Stuefe]

On Fri, 27 Oct 2023 09:32:35 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Merge master and solve merge conflicts
>>  - small fixes
>>  - start from VM op; show more thread details
>>  - start
>
> src/hotspot/os/linux/memMapPrinter_linux.cpp line 72:
> 
>> 70:       "from                 to                 "
>> 71: #else
>> 72:       "from         to         "
> 
> 16+1 and 8+1 spaces, depending on how long the addresses are I assume? Your choice, but might be good to note that.

Ok will add comment

> src/hotspot/share/services/memMapPrinter.hpp line 43:
> 
>> 41:   const void* to() const { return _to; }
>> 42:   virtual void print_details_1(outputStream* st) const {} // To be printed before VM annotations
>> 43:   virtual void print_details_2(outputStream* st) const {} // To be printed before VM annotations
> 
> May we please have better names :)?

Sure :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16301#discussion_r1374426996
PR Review Comment: https://git.openjdk.org/jdk/pull/16301#discussion_r1374425739