RFR: JDK-8318636: Add jcmd to print annotated process memory map [v4]

[Thomas Stuefe]

On Fri, 27 Oct 2023 20:20:49 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Fix spelling
>>  - timeout fuse
>>  - Feedback Johan
>
> src/hotspot/share/services/memMapPrinter.cpp line 95:
> 
>> 93: };
>> 94: 
>> 95: /// NMT virtual memory
> 
> Should we try to put all this NMT flags code into allocation.hpp?

Not allocation.hpp, but lets put it into an own header. Arguable the NMT flags should be removed from allocation.hpp and moved somewhere else, since often I find myself including allocation.hpp just for the sake of mt_number_of_flags or some minor thing.

> src/hotspot/share/services/memMapPrinter.cpp line 181:
> 
>> 179: static uintx safely_get_thread_id(const Thread* t) {
>> 180:   const OSThread* osth = t->osthread();
>> 181:   uintx tid = 0;
> 
> Leftover?

I removed the whole function

> src/hotspot/share/services/memMapPrinter.cpp line 188:
> 
>> 186: }
>> 187: 
>> 188: // Given a region [from, to) that is supposed to represent a thread stack,
> 
> Need to finish the comment?

:)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16301#discussion_r1375243877
PR Review Comment: https://git.openjdk.org/jdk/pull/16301#discussion_r1375243913
PR Review Comment: https://git.openjdk.org/jdk/pull/16301#discussion_r1375243924