RFR: 8315406: serviceability/jdwp/AllModulesCommandTest.java fails after JDK-8314834 [v4]

Daniel D. Daugherty dcubed at openjdk.org
Fri Sep 1 18:59:38 UTC 2023


On Fri, 1 Sep 2023 18:07:04 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Test failed because of unexpected output of version string. 
>> The standard convention for tests is to skip any unexpected output (version string, VM warning, vm logging) and only fail on expected error patterns. 
>> Fix is tested by running with default options and  with '-showversion' vm option.
>
> Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 8315406
>  - fix
>  - removed unused code.
>  - restore errorhandler
>  - 8315406

Is there a description in the PR or bug that describes the latest
version of this fix. I've read thru the latest changes, but I'm having
trouble putting together a picture.

-------------

Changes requested by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15499#pullrequestreview-1607500891


More information about the serviceability-dev mailing list