RFR: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags [v2]

Leonid Mesnik lmesnik at openjdk.org
Fri Sep 1 21:53:12 UTC 2023


> The fix changes test serviceability/jdwp/AllModulesCommandTest.java to accept VM flags. 
> 1) The 'ProcessTools.createTestJvm(JDWP_OPT, DEBUGGEE);'  is used to start debugee
> 2) The stderr is just logging and tests doesn't check if it is empty. stderr might contain some VM output which doesn't mean failure
> 3) Some refactoring is done. Method ' public void onStringRead(StreamHandler handler, String line) {' doesn't need to check which handler is used and corresponding code and methods are deleted. The field 'inputHandler' and 'errorHandler' were moved into method.
> 
> Tested with tier1-5 to ensure that test correctly work with CI options.
> 
> The serviceability/jdwp/AllModulesCommandTest.java is the only one test in serviceability/jdwp directory so no other tests should be affected.
> 
> I closed my previous PR https://github.com/openjdk/jdk/pull/15499 because GitHub incorrectly show changes after merge with backout if the first fix.

Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:

  Update test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java
  
  Co-authored-by: Chris Plummer <chris.plummer at oracle.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15544/files
  - new: https://git.openjdk.org/jdk/pull/15544/files/550be2ab..721a719c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15544&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15544&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/15544.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15544/head:pull/15544

PR: https://git.openjdk.org/jdk/pull/15544


More information about the serviceability-dev mailing list