RFR: 8315406: [REDO] serviceability/jdwp/AllModulesCommandTest.java ignores VM flags [v3]

Leonid Mesnik lmesnik at openjdk.org
Fri Sep 1 23:06:15 UTC 2023


On Fri, 1 Sep 2023 22:55:36 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> test/hotspot/jtreg/serviceability/jdwp/DebuggeeLauncher.java line 100:
>> 
>>> 98: 
>>> 99:     @Override
>>> 100:     public void onStringRead(String line) {
>> 
>> Is there a reason not to also echo the stdout output? Seems it would be useful if the test ever failed. Doing so probably means adding back in the StreamHandler argument.
>
> I don't like approach to compare handlers. Better to just add logging into these listeners.

updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15544#discussion_r1313615230


More information about the serviceability-dev mailing list