RFR: 8313277: Resolve multiple definition of 'normalize' when statically linking JDK native libraries with user code [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Sat Sep 2 11:09:38 UTC 2023
On Fri, 1 Sep 2023 21:11:03 GMT, Jiangli Zhou <jiangli at openjdk.org> wrote:
>> Please review this simple change from @cjmoon1 for resolving static linking issue caused by multiple definition of 'normalize'. @cjmoon1's branch can be found at: https://github.com/openjdk/jdk/compare/master...cjmoon1:jdk:fix_normalize.
>>
>> The change incorporated suggestions from both @sspitsyn and myself:
>>
>> - https://bugs.openjdk.org/browse/JDK-8313277?focusedCommentId=14604187&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14604187
>> - https://bugs.openjdk.org/browse/JDK-8313277?focusedCommentId=14604187&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14604187
>
> Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision:
>
> Update from @cjmoon1 to incorporate @dholmes-ora suggestion: https://github.com/openjdk/jdk/commit/60eebebdcfb15357701d60ca455c0708c34c43af.
Looks good.
Thanks,
Serguei
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15477#pullrequestreview-1608057378
More information about the serviceability-dev
mailing list