RFR: 8312174: missing JVMTI events from vthreads parked during JVMTI attach [v2]

Leonid Mesnik lmesnik at openjdk.org
Fri Sep 8 03:14:53 UTC 2023


On Wed, 6 Sep 2023 20:26:51 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge
>>  - 8312174: missing JVMTI events from vthreads parked during JVMTI attach
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest/VThreadEventTest.java line 136:
> 
>> 134:             ready1.await();
>> 135:             mready.decr();
>> 136:             VirtualMachine vm = VirtualMachine.attach(String.valueOf(ProcessHandle.current().pid()));
> 
> I think sleep is needed here so threads which should be unmounted have time to unmount before attach.

Would it makes sense also to check that thread state is TIMED_WAITING. It should be set  TIMED_WAITING unmounted threads https://docs.oracle.com/en/java/javase/20/docs/api/java.base/java/lang/Thread.State.html#TIMED_WAITING

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15467#discussion_r1319305453


More information about the serviceability-dev mailing list