RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies

Soumadipta Roy duke at openjdk.org
Fri Sep 8 09:41:57 UTC 2023


8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies

serviceability/sa/TestJmapCoreMetaspace.java runs in hotspot:tier2, and takes about 330 seconds out of 670 seconds of the entire run on x86_64 fastdebug. The tier2 completion usually waits on it. Profiling shows we are spending time during classloading, checking dependencies. Since we load lots of classes, we do it many times, and each time the cost grows linearly to the number of classes. Some other tests that target metaspace explicitly disable `VerifyDependencies` to avoid this.

The commit includes adding "-XX:-VerifyDependencies" along with "-XX:+IgnoreUnrecognizedVMOptions" in TestJmapCore.java to make sure that release builds work with the test, as VerifyDependencies is a develop option and not available in release builds. The changes in the commit is resulting in considerable improvement for the test in fastdebug mode as can be seen below:

* before: **130.41s user 14.11s system 118% cpu 2:01.85 total**
* after: **27.52s user 13.64s system 213% cpu 19.249 total**

-------------

Commit messages:
 - 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies

Changes: https://git.openjdk.org/jdk/pull/15631/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15631&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8315770
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/15631.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15631/head:pull/15631

PR: https://git.openjdk.org/jdk/pull/15631


More information about the serviceability-dev mailing list