RFR: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies

Aleksey Shipilev shade at openjdk.org
Fri Sep 8 09:55:40 UTC 2023


On Fri, 8 Sep 2023 09:50:59 GMT, Soumadipta Roy <duke at openjdk.org> wrote:

>> test/hotspot/jtreg/serviceability/sa/TestJmapCore.java line 76:
>> 
>>> 74:         ProcessBuilder pb = ProcessTools.createTestJvm("-XX:+CreateCoredumpOnCrash",
>>> 75:                 "-Xmx512m", "-XX:MaxMetaspaceSize=64m", "-XX:+CrashOnOutOfMemoryError",
>>> 76:                 "-XX:-VerifyDependencies", "-XX:+IgnoreUnrecognizedVMOptions",
>> 
>> Have you tried this test with `release`? I think `IgnoreUnrecognizedVMOptions` is positional, and should go before `VerifyDependencies` to actually work.
>
> I will try it and raise another commit if that is required

It would make sense to change the order, even if it works right now. This would specify what option is being ignored more clearly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15631#discussion_r1319642886


More information about the serviceability-dev mailing list