RFR: 8312174: missing JVMTI events from vthreads parked during JVMTI attach [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Fri Sep 8 14:02:41 UTC 2023


On Wed, 6 Sep 2023 20:39:59 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>> 
>>  - Merge
>>  - 8312174: missing JVMTI events from vthreads parked during JVMTI attach
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadEventTest/VThreadEventTest.java line 141:
> 
>> 139:             log("main: completedNo: " + completedNo);
>> 140:             attached = true;
>> 141:             for (Thread t : threads) {
> 
> AFAIU threads in 3rd group (TCNT3) should be unmounted (with  LockSupport.parkNanos) before they are interrupted.
> Then we need sleep here

Not sure, I understand the  suggestion.
The only interrupted threads are those in the TCN1 group as only these threads are added to the threads list.
Please, see the line 95.
Do you still think an extra timeout is needed here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15467#discussion_r1319910696


More information about the serviceability-dev mailing list