RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v2]

[Joachim Kern]

On Tue, 12 Sep 2023 04:59:13 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Joachim Kern has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   try to improve code following Davids suggestions and do some cosmetic changes
>
> src/hotspot/share/prims/jvmtiAgentList.cpp line 251:
> 
>> 249:   while (it.has_next()) {
>> 250:     JvmtiAgent* const agent = it.next();
>> 251:     if (!agent->is_static_lib() && device && inode &&
> 
> Style nit: we don't use implicit booleans so check `device != 0` and  `inode != 0` explicitly please.

I followed your suggestion

> test/jdk/com/sun/tools/attach/warnings/DynamicLoadWarningTest.java line 127:
> 
>> 125: 
>> 126:         // test behavior on platforms that can detect if an agent library was previously loaded
>> 127:         if (!Platform.isAix()) {
> 
> You need to fix the indentation of the old block.

I followed your suggestion here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15583#discussion_r1324696223
PR Review Comment: https://git.openjdk.org/jdk/pull/15583#discussion_r1324696651