RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v3]

Joachim Kern jkern at openjdk.org
Thu Sep 14 10:10:46 UTC 2023


On Thu, 14 Sep 2023 09:40:54 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Joachim Kern has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into JDK-8315706
>>  - try to improve code following Davids suggestions and do some cosmetic changes
>>  - JDK-8315706
>
> src/hotspot/share/prims/jvmtiAgent.hpp line 48:
> 
>> 46: #ifdef AIX
>> 47:   long _inode;
>> 48:   long _device;
> 
> How are dev_t and ino_t defined on AIX, I'm wondering if long is okay here.

They are defined as __ulong64_t which is unsigned long. So I can change it to unsigned long or even to dev_t and ino_t.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15583#discussion_r1325721375


More information about the serviceability-dev mailing list