RFR: JDK-8315706: com/sun/tools/attach/warnings/DynamicLoadWarningTest.java real fix for failure on AIX [v4]

[David Holmes]

On Thu, 14 Sep 2023 12:32:18 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> After push of [JDK-8307478](https://bugs.openjdk.org/browse/JDK-8307478) , the following test started to fail on AIX :
>> com/sun/tools/attach/warnings/DynamicLoadWarningTest.java;
>> The problem was described in [JDK-8309549](https://bugs.openjdk.org/browse/JDK-8309549) with a first try of a fix.
>> A second fix via [JDK-8310191](https://bugs.openjdk.org/browse/JDK-8310191) was necessary.
>> Both fixes just disable the specific subtest on AIX, without correction of the root cause.
>> The root cause is, that dlopen() on AIX returns different handles every time, even if you load a library twice. There is no official AIX API available to get this information on a different way.
>> My proposal is, to use the stat64x API with the fields st_device and st_inode. After a dlopen() the stat64x() API is called additionally to get this information which is then stored parallel to the library handle in the jvmtiAgent. For AIX we then can compare these values instead of the library handle and get the same functionality as on linux.
>
> Joachim Kern has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/JDK-8315706' into JDK-8315706
>  - Following the proposals

Changes requested by dholmes (Reviewer).

src/hotspot/share/prims/jvmtiAgent.hpp line 48:

> 46: #ifdef AIX
> 47:   unsigned long _inode;
> 48:   unsigned long _device;

It is best, IMO, to use the actual types rather than something expected to be "equivalent".

-------------

PR Review: https://git.openjdk.org/jdk/pull/15583#pullrequestreview-1628087511
PR Review Comment: https://git.openjdk.org/jdk/pull/15583#discussion_r1326697271