RFR: 8316417: ObjectMonitorIterator does not return the most recent monitor and is incorrect if no monitors exists [v2]

Axel Boldt-Christmas aboldtch at openjdk.org
Mon Sep 18 12:08:17 UTC 2023


> ObjectMonitorIterator fails to return the most resent monitor added. It start with returning the `nextOM()` ObjectMonitor from the `_head` ObjectMonitor but fails to ever return the `_head` ObjectMonitor.
> The current implementation can also not handle that the `_head` is nullptr (no monitors in the system) and returns a null ObjectMonitorIterator. Which is interpreted as `monitor list not supported, too old hotspot VM`.
> 
> Changed the iterator to keep return the current monitor (starts with `_head`) and decoupled `_head == nullptr` from the question if ObjectMonitorIterator is supported. 
> 
> Testing:
>   * Passes all `serviceability/sa` tests
>   * Currently running tier 1-3
>   * Currently running GHA

Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:

  Avoid changing the LingeredApp class hierarchy for CDS tests ergonomics

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/15782/files
  - new: https://git.openjdk.org/jdk/pull/15782/files/1c29f066..9376d8fe

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=15782&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=15782&range=00-01

  Stats: 4 lines in 2 files changed: 0 ins; 2 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/15782.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/15782/head:pull/15782

PR: https://git.openjdk.org/jdk/pull/15782


More information about the serviceability-dev mailing list