RFR: JDK-8313804: JDWP support for -Djava.net.preferIPv6Addresses=system [v3]

Liam Miller-Cushon cushon at openjdk.org
Tue Sep 19 15:41:28 UTC 2023


On Tue, 19 Sep 2023 11:03:36 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Liam Miller-Cushon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review feedback
>
> test/jdk/com/sun/jdi/JdwpNetProps.java line 75:
> 
>> 73:                     .run(TestResult.Success);
>> 74:             if (ipv6Address != null) {
>> 75:                 // - only IPv4, so connection prom IPv6 should fail
> 
> Is there an existing typo here, I assume "prom" should be "from"?

I agree: that is pre-existing, and it is a typo for 'from'. I am happy to fix it while I'm here if you like.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15796#discussion_r1330329489


More information about the serviceability-dev mailing list