RFR: JDK-8315486: vmTestbase/nsk/jdwp/ThreadReference/ForceEarlyReturn/forceEarlyReturn002/forceEarlyReturn002.java timed out [v2]

Leonid Mesnik lmesnik at openjdk.org
Tue Sep 19 16:41:42 UTC 2023


On Thu, 7 Sep 2023 01:25:19 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> To test ForceEarlyReturn command for NO_MORE_FRAMES case the test creates ThreadStartEventRequest with SUSPEND_ALL policy and requests debuggee to start new thread.
>> If debuggee JVM starts some internal threads before the request is cleared (i.e. we have several ThreadStart events), 2nd event suspends debuggee again and the test fails with timeout.
>> The change adds THREAD_ONLY modifier to the ThreadStartEventRequest to generate event only for desired thread.
>> It requires thread ID, so debuggee was updated to create Thread object in advance, debugger reads the thread ID from static field (it does not need to be static, but Debugee class has convenient methods to retrieve class ID and static field value).
>> 
>> Testing: 100 runs of the test on windows-x64-debug,linux-x64-debug,macosx-x64-debug with JTREG_TEST_THREAD_FACTORY=Virtual, with and without "-XX:+UseZGC -XX:+ZGenerational"
>
> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Chris feedback - enhanced comment

Marked as reviewed by lmesnik (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15601#pullrequestreview-1633746941


More information about the serviceability-dev mailing list