RFR: 8316562: serviceability/sa/jmap-hprof/JMapHProfLargeHeapTest.java times out after JDK-8314829

[David Holmes]

On Wed, 20 Sep 2023 05:23:12 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> OutputAnalyzer 'firstmatch' method analyze result. It analyze string from 'String OutputBuffer getStdout()' and can't be used to communicate with process.

Ah I see.

> Something like this was my first fix. Use largeHeapScanner.nextLine() to read String and check it. However, it makes unclear why a scanner is needed for line-by-line parsing. So I decided to change it to make a more known pattern for parsing input by line.

I must admit I'm unclear on why scanner was used here, but it would have made the fix much smaller/simpler.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15833#issuecomment-1726995178
PR Comment: https://git.openjdk.org/jdk/pull/15833#issuecomment-1726996116