RFR: 8316658: serviceability/jvmti/RedefineClasses/RedefineLeakThrowable.java fails intermittently
Coleen Phillimore
coleenp at openjdk.org
Fri Sep 22 14:45:15 UTC 2023
On Fri, 22 Sep 2023 08:36:10 GMT, Jean-Philippe Bempel <jpbempel at openjdk.org> wrote:
> increase Metaspace size and loop count to avoid OOME in nominal case
This seems okay if it helps the test run reliably. I don't know a better way to test the absence of a memory leak. If this fails again, maybe we need to rewrite RedefineClassHelper to only generate the class bytes once, not each time.
This is a trivial change and seems to already have David's implicit approval in the CR, so I don't think you need to wait 24 hours. You can if you want though.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15882#pullrequestreview-1640111084
More information about the serviceability-dev
mailing list