RFR: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper [v3]

Leonid Mesnik lmesnik at openjdk.org
Fri Sep 22 23:38:49 UTC 2023


On Fri, 22 Sep 2023 22:50:58 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> It may break the tests that check this property in static initializers of debugee. In such case method could be called before main() and return an empty value if a property is not set yet.
>> 
>> Probably the DebuggerWrapper requires more documentation about it's usage. I could add it separately with refactoring.,
>
> Is it necessary to pass the wrapper argument if we are setting main.wrapper property? Can't DebuggeeWrapper just pick up the wrapper type from the property instead of the wrapper argument?

That's reasonable.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15874#discussion_r1334881237


More information about the serviceability-dev mailing list