RFR: 8304839: Move TestScaffold.main() to the separate class DebugeeWrapper [v3]

Chris Plummer cjplummer at openjdk.org
Sat Sep 23 00:50:24 UTC 2023


On Fri, 22 Sep 2023 23:38:49 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> The code related to virtual threads support is moved into a separate class DebugeeWrapper.
>> 
>> The code of method main() remains the same. I don't mix code change with moving code between files.
>> 
>> Tesed by running 
>> make run-test JTREG_RETAIN=all  TEST=com/sun/jdi
>> make run-test JTREG_RETAIN=all  JTREG_TEST_THREAD_FACTORY=Virtual TEST=com/sun/jdi
>> locally and tier1 and hs-tier5 in Mach5 CI
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed

Looks good. Can you do a test run using TEST_VM_OPTS set to something? Maybe try with -Xcomp. Just want to make sure VM argument passing is working.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15874#pullrequestreview-1640755933


More information about the serviceability-dev mailing list