RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v5]

Afshin Zafari azafari at openjdk.org
Tue Sep 26 10:21:19 UTC 2023


On Tue, 26 Sep 2023 09:02:48 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> The `find` method now is 
>> ```C++
>> template<typename T>
>> int find(T* token, bool f(T*, E)) const {
>> ...
>> 
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and Windows passed.
>
> Afshin Zafari has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into _8314502
>  - changed the `E` param of find methods to `const E&`.
>  - find_from_end and its caller are also updated.
>  - 8314502: Change the comparator taking version of GrowableArray::find to be a template method
>  - 8314502: GrowableArray: Make find with comparator take template

Dear reviewers @kimbarrett, @dholmes-ora, @stefank, @sspitsyn and @merykitty, 
Would you please check if you have any more comments on this? Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15418#issuecomment-1735248312


More information about the serviceability-dev mailing list