RFR: 8315966: Relativize initial_sp in interpreter frames [v2]
Fredrik Bredberg
fbredberg at openjdk.org
Tue Sep 26 11:46:16 UTC 2023
On Wed, 20 Sep 2023 08:46:39 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Updated after review.
>
> src/hotspot/cpu/riscv/interp_masm_riscv.cpp line 704:
>
>> 702: // register for unlock_object to pass to VM directly
>> 703: ld(c_rarg1, monitor_block_top); // derelativize pointer
>> 704: shadd(c_rarg1, c_rarg1, fp, c_rarg1, LogBytesPerWord);
>
> Nit: One redundant space between the 3rd and 4th parameters for each `shadd` call added.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15815#discussion_r1337078087
More information about the serviceability-dev
mailing list