RFR: 8315149: Add hsperf counters for CPU time of internal GC threads [v24]

Volker Simonis simonis at openjdk.org
Tue Sep 26 13:19:17 UTC 2023


On Tue, 19 Sep 2023 22:48:16 GMT, Jonathan Joo <jjoo at openjdk.org> wrote:

>> 8315149: Add hsperf counters for CPU time of internal GC threads
>
> Jonathan Joo has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix build issues

Thanks for your continued work on this PR. I think it looks pretty good now once you fix the `long`/`jlong` issue mentioned by @dholmes-ora. And the solution proposed by @shipilev should work equally well on arm32.

src/hotspot/share/gc/shared/stringdedup/stringDedupThread.cpp line 31:

> 29: #include "runtime/handles.hpp"
> 30: #include "runtime/os.hpp"
> 31: #include "runtime/perfData.hpp"

This include doesn't seem to be needed?

-------------

PR Review: https://git.openjdk.org/jdk/pull/15082#pullrequestreview-1644233704
PR Review Comment: https://git.openjdk.org/jdk/pull/15082#discussion_r1337186614


More information about the serviceability-dev mailing list