RFR: 8299915: Remove ArrayAllocatorMallocLimit and associated code [v4]

David Holmes dholmes at openjdk.org
Tue Sep 26 20:57:15 UTC 2023


On Tue, 26 Sep 2023 08:35:10 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> 1. `ArrayAllocatorMallocLimit` is removed. The test cases that tested it also are removed.
>> 2. `AllocArrayAllocator` instances are replaced with `MallocArrayAllocator`.
>> 3. The signature of `CHeapBitMap::free(ptr, size)` is kept as it is, since it is called in this way from `GrowableBitMap<T>::resize`, where `T` can be also `ArenaBitMap` and `ResourceBitMap`. However, it uses `MallocArrayAllocator::free(ptr)` and ignores the `size`:
>> ```C++
>> void CHeapBitMap::free(bm_word_t* map, idx_t size_in_words) const { 
>>  MallocArrayAllocator<bm_word_t>::free(map);
>> }
>> 
>> ### Test
>> tiers1-4 passed on all platforms.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   MetaspaceSize and its lower bound is used.

Thanks for test changes. Seems fine. Thanks.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15859#pullrequestreview-1645194241


More information about the serviceability-dev mailing list