RFR: JDK-8219652: [aix] Tests failing with JNI attach problems. [v2]

[Varada M]

On Tue, 26 Sep 2023 15:48:01 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Varada M has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - AttachCurrentThread() failure solution
>>  - Revert "AttachCurrentThread() failure solution"
>>    
>>    This reverts commit b2648f02ba7e693eca99074849a1b503c0b9d30c.
>
> test/hotspot/jtreg/ProblemList.txt line 155:
> 
>> 153: 
>> 154: vmTestbase/nsk/jvmti/AttachOnDemand/attach045/TestDescription.java 8202971 generic-all
>> 155: vmTestbase/nsk/jvmti/scenarios/jni_interception/JI06/ji06t001/TestDescription.java 8219652 aix-ppc64
> 
> It looks like you need to remove this entry also.

Is it like we should create separate PR to remove/add tests from ProblemList ?

> test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/jni_interception/JI06/ji06t001/ji06t001.cpp line 52:
> 
>> 50:           NSK_DISPLAY0("Detaching thread ...\n"); \
>> 51:           return 0; \
>> 52:       exit(-1); \
> 
> The indent of the  `return statement` is wrong. It's at the same level as the `exit()`, which means the `exit()` is never executed.
> 
> This code now ignores the `status` argument, so it doesn't seem to be correct.
> 
> I'm not sure why any of the changes here were necessary.

@plummercj I have applied changes to native_thread.cpp instead of changing in every executables. Please review the change. It will be working fine on windows as well.

Thank you

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15924#discussion_r1338219781
PR Review Comment: https://git.openjdk.org/jdk/pull/15924#discussion_r1338219919