RFR: 8316401: sun/tools/jhsdb/JStackStressTest.java failed with "InternalError: We should have found a thread that owns the anonymous lock" [v2]

Chris Plummer cjplummer at openjdk.org
Wed Sep 27 19:25:17 UTC 2023


On Wed, 27 Sep 2023 17:54:51 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> The SA can run concurrently with Java threads, SA code that inspects locking state should be able to deal with that. On the other hand, the particular code is only used in printing routine and is not expected to be precise. When resolving an anonymous owner, we may not find one, because Java threads may already have moved on. Instead of crashing with a stacktrace, we should gracefully return null here.
>> 
>> Testing:
>>  - [x] sun/tools/jhsdb/JStackStressTest.java
>>  - [x] sun/tools/jhsdb
>>  - [x] serviceability/sa
>
> Roman Kennke has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Print warning when anonymous lock cannot be found

Looks good. Thanks!

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/15907#pullrequestreview-1647405613


More information about the serviceability-dev mailing list