RFR: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code

Chris Plummer cjplummer at openjdk.org
Wed Sep 27 22:46:46 UTC 2023


On Wed, 27 Sep 2023 20:23:03 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

> The main.wrapper was the first name for jtreg test thread factory plugin. However, during integration of this feature in jtreg it was decided to use test.thread.factory name. So this fix just renames "main.wrapper" property to  "test.thread.factory" so it is more compliant with jtreg naming. Also, it makes more sense for tests when it is used to create other then main threads in test.
> Testing: tier1-5.
> Verified that "main.wrapper" is not used in test sources anymore.
> 
> I haven't rename DebugeeWrapperd and MainWrapper classes in JDI test frameworks because they are actually more main wrappers than thread factories.

test/hotspot/jtreg/vmTestbase/nsk/share/runner/RunParams.java line 228:

> 226:                 }
> 227:                 // Allow to force using vthreads using wrapper property
> 228:                 if(System.getProperty("test.thread.factory") != null && System.getProperty("test.thread.factory").equals("Virtual")) {

I think there are better examples of how to do this in the diffs above. Maybe a good time to clean it up.

test/lib/jdk/test/lib/process/ProcessTools.java line 390:

> 388: 
> 389:     /*
> 390:       Convert arguments for tests running with virtual threads test thread factory

Add a period at the end of the first sentence.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15950#discussion_r1339299467
PR Review Comment: https://git.openjdk.org/jdk/pull/15950#discussion_r1339300522


More information about the serviceability-dev mailing list