RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v5]

David Holmes dholmes at openjdk.org
Thu Sep 28 02:07:23 UTC 2023


On Wed, 27 Sep 2023 08:48:27 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> src/hotspot/share/gc/parallel/mutableNUMASpace.hpp line 1:
>> 
>>> 1: /*
>> 
>> This seems an unrelated change.
>
> This change came after fixing a merge conflict.
> In `mutableNUMASpace.cpp`, at lines 163, 182, 202 and 586 the `find` function is called in this way: 
> 
> int i = lgrp_spaces()->find(&lgrp_id, LGRPSpace::equals);
> 
> where `lgrp_id` is `int`. Therefore, the `LGRPSpace::equals` has to take an `int*` in its first argument. The definition of `find` is:
> 
> int find(T* token, bool f(T*, const E&)) const {

After JDK-8316115 `lgrp_id` is `uint`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15418#discussion_r1339427450


More information about the serviceability-dev mailing list