RFR: 8313997: The jdi/ListeningConnector/startListening/startlis001 may fail if the hosts file is modified

Serguei Spitsyn sspitsyn at openjdk.org
Thu Sep 28 15:31:29 UTC 2023


On Wed, 9 Aug 2023 07:46:58 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> The test uses this code to create a list of valid addresses for the localhost:
> 
>         String hostname = "localhost";
>         List<String> validAddresses = new LinkedList<>();
>         validAddresses.add(hostname);
>         Arrays.stream(InetAddress.getAllByName(hostname))
>                     .forEach(address -> validAddresses.add(address.getHostAddress()));
> 
> It does not work properly if the custom name is set for the 127.0.01 via /etc/hosts file. In that case, the address returned by the "startListen()" will be "SomeCustomName:port", for example we can return it here:
> https://github.com/openjdk/jdk/blob/360f65d7b15b327e2f160c42f318945cc6548bda/src/jdk.jdi/share/classes/com/sun/tools/jdi/SocketTransportService.java#L82

test/hotspot/jtreg/vmTestbase/nsk/jdi/ListeningConnector/startListening/startlis001.java line 108:

> 106:         List<String> validAddresses = new LinkedList<>();
> 107:         makeValidAddresses("localhost", validAddresses);
> 108:         try {

Why try-catch is needed here?
The `UnknownHostException` has been already caught in `makeValidAddresses`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15203#discussion_r1340332820


More information about the serviceability-dev mailing list