RFR: 8314502: Change the comparator taking version of GrowableArray::find to be a template method [v6]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Sep 28 16:54:37 UTC 2023
On Thu, 28 Sep 2023 09:49:05 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
>> The `find` method now is
>> ```C++
>> template<typename T>
>> int find(T* token, bool f(T*, E)) const {
>> ...
>>
>> Any other functions which use this are also changed.
>> Local linux-x64-debug hotspot:tier1 passed. Mach5 tier1 build on linux and Windows passed.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>
> first arg of `find` casted to `uint*`
Marked as reviewed by sspitsyn (Reviewer).
The serviceability files look good.
By being paranoid I'd suggest to run more tiers, eg. 3-4.
-------------
PR Review: https://git.openjdk.org/jdk/pull/15418#pullrequestreview-1649318449
PR Comment: https://git.openjdk.org/jdk/pull/15418#issuecomment-1739688410
More information about the serviceability-dev
mailing list