RFR: 8303773: Replace "main.wrapper" with "test.thread.factory" property in test code [v2]
Chris Plummer
cjplummer at openjdk.org
Thu Sep 28 18:15:27 UTC 2023
On Thu, 28 Sep 2023 16:47:09 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:
>> The main.wrapper was the first name for jtreg test thread factory plugin. However, during integration of this feature in jtreg it was decided to use test.thread.factory name. So this fix just renames "main.wrapper" property to "test.thread.factory" so it is more compliant with jtreg naming. Also, it makes more sense for tests when it is used to create other then main threads in test.
>> Testing: tier1-5.
>> Verified that "main.wrapper" is not used in test sources anymore.
>>
>> I haven't rename DebugeeWrapperd and MainWrapper classes in JDI test frameworks because they are actually more main wrappers than thread factories.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>
> fix
Just one minor formatting request. Otherwise changes look good.
test/hotspot/jtreg/vmTestbase/nsk/share/runner/RunParams.java line 228:
> 226: }
> 227: // Allow to force using vthreads using wrapper property
> 228: if("Virtual".equals(System.getProperty("test.thread.factory"))) {
Need a space after the `if`.
-------------
Marked as reviewed by cjplummer (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15950#pullrequestreview-1649456102
PR Review Comment: https://git.openjdk.org/jdk/pull/15950#discussion_r1340513706
More information about the serviceability-dev
mailing list