RFR: 8316342: CLHSDB "dumpclass" command produces invalid classes

[Chris Plummer]

On Thu, 28 Sep 2023 21:23:25 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

> Please review this change to fix the operands of the bytecodes that operate on fields when dumping a class using SA.
> 
> Testing: hotspot_serviceability
> 
> I have also verified that `test/hotspot/jtreg/serviceability/sa/ClhsdbDumpclass.javaClhsdbDumpclass.java`, which is in the problem list because of this issue, passes with this change.
> I have also verified it by dumping the class that has getstatic/putstatic bytecodes and comparing the bytecodes manually with the original classfile.

Marked as reviewed by cjplummer (Reviewer).

Ok. The changes look good to me, but I don't have much of understanding of the hotspot code involved here, so I'll defer to a hotspot expert for the 2nd review.

-------------

PR Review: https://git.openjdk.org/jdk/pull/15973#pullrequestreview-1649841033
PR Comment: https://git.openjdk.org/jdk/pull/15973#issuecomment-1740128385