RFR: 8337563: NMT: rename MEMFLAGS to MemFlag

Stefan Karlsson stefank at openjdk.org
Wed Aug 14 06:56:49 UTC 2024


On Tue, 13 Aug 2024 16:30:01 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

> Is everyone OK with MemTypeFlag?

It's quite unfortunate to have a three-word type for something this prolific in our code base. Why not go with `MemType` and change variable names from `flag` to `mt`?


  static char* map_memory_to_file(size_t size, int fd, MEMFLAGS flag = mtNone);

would then become:

  static char* map_memory_to_file(size_t size, int fd, MemType mt = mtNone);

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2287987726


More information about the serviceability-dev mailing list