RFR: 8338469: com/sun/jdi/DataDumpTest.java failed with Not a debuggee, or not listening for debugger to attach [v2]

Daniel D. Daugherty dcubed at openjdk.org
Fri Aug 16 16:35:48 UTC 2024


On Fri, 16 Aug 2024 16:31:01 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> There are issues with the test attaching to the debuggee too soon, and the debug agent isn't ready. yet. This test is based on ProcessAttachTest, which does not have this issue. I eventually realized the reason why is because ProcessAttachTest has this little snippet of code, which I had removed from DataDumpTest:
>> 
>>              // Wait for the process to start
>>             InputStream is = p.getInputStream();
>>             is.read(); 
>> 
>> This is waiting for the start of the debug agent's "Listening..." message. I've re-added this to DataDumpTest, and it seems to fix the issue. Tested by running 20 times with `-Xcomp` on all supported platforms with no failures. It used to fail about 2/3 of the time.
>
> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix typo in output

Thumbs up. Thanks for fixing the typo.

This is a trivial fix.

-------------

Marked as reviewed by dcubed (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/20604#pullrequestreview-2243090019


More information about the serviceability-dev mailing list