RFR: 8335625: Update Javadoc for GetCpuLoad [v3]

Joakim Nordström jnordstrom at openjdk.org
Mon Aug 26 14:00:08 UTC 2024


On Mon, 26 Aug 2024 13:51:08 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Reviewing the current implementation this seems to be the case. 
>> 
>> The `@implNote` was more meant as an explanation to why the result could be affected by other callers. Since the `@apiNote` also states that the "observation period and result" can be affected, I think its an unnecessary implementation note to have.
>
> Okay, if this is the case for all implementations then it would be okay to use "In the JDK implementation, there is only one ...".

Then again, I don't know the purpose the comment serves. 

For Windows, the observation period is at least 500 ticks. There is however still only one observation period, meaning any caller using this method will change that observation period.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20546#discussion_r1731290003


More information about the serviceability-dev mailing list