RFR: 8337563: NMT: rename MEMFLAGS to MemFlag
Thomas Stüfe
thomas.stuefe at gmail.com
Thu Aug 29 15:25:43 UTC 2024
Note that “NMT::MemType” may lead to many uses of just “MemType” since a
lot of the usage will happen inside a future NMT namespace and people will
just drop the namespace. Will make it a bit more difficult to grep for,
since you need to look for both variants.
Adding an NMT namespace also opens other questions. E.g. writing - all
lower case is the standard.
On Thu 29. Aug 2024 at 17:15, Gerard Ziemski <gziemski at openjdk.org> wrote:
> On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski <gziemski at openjdk.org>
> wrote:
>
> > Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
> >
> > `MEMFLAGS` implies that we can use more than one at the same time, but
> those are exclusive values, so `MemType` is much more suitable name.
> >
> > There is a bunch of other related cleanup that we can do, but I will
> leave for follow up issues such as [NMT: rename NMTUtil::flag to
> NMTUtil::type](https://bugs.openjdk.org/browse/JDK-8337836)
>
> Taking Dan's feedback into account we have:
>
> -------------
>
> PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2318039929
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/serviceability-dev/attachments/20240829/2e6d22fa/attachment-0001.htm>
More information about the serviceability-dev
mailing list