RFR: 8337563: NMT: rename MEMFLAGS to MemFlag
Coleen Phillimore
coleenp at openjdk.org
Fri Aug 30 17:01:21 UTC 2024
On Wed, 7 Aug 2024 17:13:06 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
> Please review this cleanup, where we rename `MEMFLAGS` to `MemType`.
>
> `MEMFLAGS` implies that we can use more than one at the same time, but those are exclusive values, so `MemType` is much more suitable name.
>
> There is a bunch of other related cleanup that we can do, but I will leave for follow up issues such as [NMT: rename NMTUtil::flag to NMTUtil::type](https://bugs.openjdk.org/browse/JDK-8337836)
Yes, I think people want the name of the new type, and variables that are declared with this type changed in one PR. Just looking through a bit of this webrev, this looks fine. This isn't very hard to review.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/20497#issuecomment-2321978633
More information about the serviceability-dev
mailing list