RFR: 8339112: Move JVM Klass flags out of AccessFlags [v3]

[Coleen Phillimore]

On Fri, 30 Aug 2024 20:22:38 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Fix jvmci code.
>>  - Some C2 refactoring.
>>  - Assembly corrections from Matias and Dean.
>
> src/hotspot/share/opto/library_call.cpp line 3777:
> 
>> 3775:   Node* p = basic_plus_adr(kls, in_bytes(Klass::misc_flags_offset()));
>> 3776:   Node* mods = make_load(nullptr, p, TypeInt::UBYTE, T_BOOLEAN, MemNode::unordered);
>> 3777:   return generate_mods_flags_guard(mods, modifier_mask, modifier_bits, region);
> 
> Suggestion:
> 
>   return generate_mods_flags_guard(mods, modifier_mask, modifier_bits, region, Klass::misc_flags_offset(), TypeInt::UBYTE, T_BOOLEAN);
> 
> This looks much better, but can't you leave the basic_plus_adr and make_load in generate_mods_flags_guard, and pass in the needed specialization?

Really, this is better? it adds three parameters.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20719#discussion_r1739430586