RFR: 8339307: jhsdb jstack could not trace FFM upcall frame [v2]

[Yasumasa Suenaga]

On Fri, 30 Aug 2024 20:28:11 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> Thanks for fixing this. The SA changes look fine. You'll need an FFM expert for the hotspot changes.

Thank you!

> Is it possible to provide a test case? Maybe make a call into some blocking native API and then run jstack on the process.

I added the test for this. It passes the address of upcall to JNI, then JNI func calls it.

> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/UpcallStub.java line 46:
> 
>> 44:     Type type = db.lookupType("UpcallStub");
>> 45: 
>> 46:     // FIXME: add any needed fields
> 
> I think you can remove this comment since clearly none of the fields are needed by SA.

Removed this comment

-------------

PR Comment: https://git.openjdk.org/jdk/pull/20789#issuecomment-2322761384
PR Review Comment: https://git.openjdk.org/jdk/pull/20789#discussion_r1739599883