RFR: 8345286: Remove use of SecurityManager API from misc areas [v6]

Alan Bateman alanb at openjdk.org
Mon Dec 2 14:31:40 UTC 2024


On Mon, 2 Dec 2024 14:24:57 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which removes usages of SecurityManager related APIs and some leftover related to SecurityManager changes?
>> 
>> This addresses https://bugs.openjdk.org/browse/JDK-8345286. Most of these changes are trivial. The `src/java.base/linux/classes/jdk/internal/platform/CgroupUtil.java` used to expose utility methods for dealing with SecurityManager permissions and it was called from a few places. That class is no longer needed with the clean up done in this PR.
>> 
>> No new tests have been introduced and tier testing is currently in progress.
>
> Jaikiran Pai has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - remove unused import
>  - replace remaining Paths.get() with Path.of() in the updated files

Marked as reviewed by alanb (Reviewer).

src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java line 3:

> 1: /*
> 2:  * Copyright (c) 2020, 2022, Red Hat Inc.
> 3:  * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.

Not sure about this as it's not a significant change to the file.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22478#pullrequestreview-2472853631
PR Review Comment: https://git.openjdk.org/jdk/pull/22478#discussion_r1865945081


More information about the serviceability-dev mailing list