RFR: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id
Coleen Phillimore
coleenp at openjdk.org
Tue Dec 3 23:00:37 UTC 2024
On Tue, 3 Dec 2024 19:10:55 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:
> Please review this small renaming patch. During the review of JDK-8338383 there were some comments about improving the naming for `ObjectMonitor::owner_from()` and `JavaThread::_lock_id`. These originate from the changes introduced to inflated monitors, where we now record the `java.lang.Thread.tid` of the owner in the ObjectMonitor's `_owner` field instead of a `JavaThread*`. I renamed `_lock_id` as `_monitor_owner_id` and `owner_from()` as `owner_id_from()`.
>
> Thanks,
> Patricio
Renaming looks good and makes it clearer what the id is.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22524#pullrequestreview-2476917190
More information about the serviceability-dev
mailing list