RFR: 8345422: Fix JNI Checker "in native method" warnings in the debug agent and debugger tests

[Alex Menkov]

On Tue, 3 Dec 2024 20:16:33 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> The root cause of [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) seems to be some JNI Checker warnings. I decided to resolve all the warnings in the debug agent and debugger tests that start with "in native method". This seems to have resolved [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) failure. There are still other JNI Checker warnings present that are not being dealt with at this time.
> 
> Testing:
> - [x] All tier1
> - [x] All tier2 svc tests
> - [x] All tier3 svc tests
> - [x] All tier4, which is where [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) reproduced
> - [x] All tier5 svc tests

src/jdk.jdwp.agent/share/native/libjdwp/invoker.c line 342:

> 340: 
> 341: static void
> 342: saveGlobalRefHelper(JNIEnv *env, jobject obj, jobject *pobj)

Do we need to call `saveGlobalRefHelper` instead of `saveGlobalRef `in `invokeNonvirtual`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22528#discussion_r1870286694