RFR: 8345422: Fix JNI Checker "in native method" warnings in the debug agent and debugger tests [v2]

[Chris Plummer]

On Thu, 5 Dec 2024 00:56:25 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> The root cause of [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) seems to be some JNI Checker warnings. I decided to resolve all the warnings in the debug agent and debugger tests that start with "in native method". This seems to have resolved [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) failure. There are still other JNI Checker warnings present that are not being dealt with at this time.
>> 
>> Testing:
>> - [x] All tier1
>> - [x] All tier2 svc tests
>> - [x] All tier3 svc tests
>> - [x] All tier4, which is where [JDK-8344804](https://bugs.openjdk.org/browse/JDK-8344804) reproduced
>> - [x] All tier5 svc tests
>
> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use saveGlobalRefHelper() for invokeNonvirtual()

src/jdk.jdwp.agent/share/native/libjdwp/invoker.c line 564:

> 562:         request->returnValue.l = NULL;
> 563:         if (object != NULL) {
> 564:             JDI_ASSERT_MSG(JNI_FALSE, "invokeNonvirtual with Object returned type");

Sorry, this crept in last commit. I'll remove.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22528#discussion_r1870483169