RFR: 8319875: Add macOS implementation for jcmd System.map [v11]

[Simon Tooke]

On Thu, 5 Dec 2024 17:45:06 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix trailing whitesdpae errors
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 99:
> 
>> 97:     if (valid_share_mode) {
>> 98:       int share_mode = rinfo.pri_share_mode;
>> 99:       out.print_raw(share_strings[share_mode - 1]);
> 
> this makes me nervous. Please do a bounds check beforehand. Assert is fine. Who knows if Apple changes the numeric definitions for SM_xxx

Done.

> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 107:
> 
>> 105: 
>> 106: #define X1(TAG, DESCR) X2(TAG, DESCR)
>> 107: //#define X1(TAG) case VM_MEMORY_ ## TAG: return # TAG;
> 
> remnant?

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20953#discussion_r1871914886
PR Review Comment: https://git.openjdk.org/jdk/pull/20953#discussion_r1871915109