RFR: 8319875: Add macOS implementation for jcmd System.map [v12]

[Simon Tooke]

On Sat, 7 Dec 2024 08:34:45 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   combine like 128MB regions
>
> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 97:
> 
>> 95:       _file_name.print_raw(mem_info.prp_vip.vip_path);
>> 96:     }
>> 97:     /* proc_regionfilename() seems to give bad results, so we don't try to use it here. */
> 
> We use // in cpp for most cases

done.

> src/hotspot/os/bsd/memMapPrinter_macosx.cpp line 113:
> 
>> 111:       "cow", "pvt", "---", "shr", "tsh", "p/a", "s/a", "lpg"
>> 112:     };
>> 113:     assert(SM_COW == 1 && SM_LARGE_PAGE == 8, "share_mode contants are out of range");
> 
> Suggestion:
> 
>     assert(SM_COW == 1 && SM_LARGE_PAGE == (sizeof(share_strings)/sizeof(share_strings[0]), "share_mode contants are out of range"); // the +1 offset is intentional, see below

done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20953#discussion_r1875923602
PR Review Comment: https://git.openjdk.org/jdk/pull/20953#discussion_r1875924001